Add the ability to add an app shortcut to open chuck from the launcher icon#49
Open
degill wants to merge 1 commit intojgilfelt:masterfrom
degill:dg_app_shortcut
Open
Add the ability to add an app shortcut to open chuck from the launcher icon#49degill wants to merge 1 commit intojgilfelt:masterfrom degill:dg_app_shortcut
degill wants to merge 1 commit intojgilfelt:masterfrom
degill:dg_app_shortcut
Conversation
degill
changed the title
degill
changed the title
olivierperez
suggested changes
Sep 19, 2018
olivierperez
left a comment
olivierperez
left a comment
There was a problem hiding this comment.
You should maybe add a method to remove the shortcut too.
| final String id = context.getPackageName() + ".chuck_ui"; | ||
| final ShortcutManager shortcutManager = context.getSystemService(ShortcutManager.class); | ||
| final ShortcutInfo shortcut = new ShortcutInfo.Builder(context, id).setShortLabel("Chuck") | ||
| .setLongLabel("Open Chuck UI") |
There was a problem hiding this comment.
The label should be retrieved from the resources, or maybe given by paramters to let de developer choose the wording.
| * It can be used if you want to remove this shortcut later on. | ||
| */ | ||
| @TargetApi(Build.VERSION_CODES.N_MR1) | ||
| @SuppressWarnings("WeakerAccess") |
There was a problem hiding this comment.
I'm not fan of this SuppressWarnings
Author
There was a problem hiding this comment.
This function is obviously not called from within the library, thus there will be a warning that its access can be weaker, but apps need access to it so it must be public -> Get rid of the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to add an app shortcut to the clients' launcher icon on android devices running android 7.0 and above. With that app shortcut the Chuck UI can be accessed. This can be useful if no notification is desired but there still need to be a simple way to enter chuck.